-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
urdf_parser/test/memtest.cpp
Outdated
@@ -3,6 +3,7 @@ | |||
#include <iostream> | |||
|
|||
int main(int argc, char** argv){ | |||
(void) argc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, rather than doing this, I think we should fix this main
up, since it is buggy.
That is, if it ever got called with no arguments, it would index past the end of argv below and crash.
My suggestion here is to add:
if (argc != 2) {
fprintf(stderr, "Usage: %s <urdf>\n", argv[0]);
return 1;
}
And also add a return 0;
to the end of the function for completeness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with green CI.
For the MacOS CI, it seems that including ros/console_bridge#64 seems to be the solution to this problem. It was merged-in in May before the
|
Actually, this is misleading because the issue with macOS in this case is that the wrong headers are being applied. |
0a917ab
to
c67038a
Compare
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@audrow So, I've now moved main ROS 2 development for this package over to https://github.com/ros/urdfdom. Could you please move this PR over to that repository and close this one out? Thanks. |
I've moved this PR over to ros#148. |
No description provided.